Re: [Qemu-block] [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code

[Kevin Wolf]

Am 10.08.2017 um 00:43 hat Paolo Bonzini geschrieben:
> 
> 
> ----- Original Message -----
> > From: "Eric Blake" <address@hidden>
> > To: "Paolo Bonzini" <address@hidden>, address@hidden
> > Cc: address@hidden, address@hidden
> > Sent: Thursday, August 10, 2017 12:18:54 AM
> > Subject: Re: [Qemu-devel] [PATCH 01/12] qemu-iotests: remove dead code
> > 
> > On 08/09/2017 04:54 PM, Paolo Bonzini wrote:
> > > This includes shell function, shell variables, command line options
> > > (randomize.awk does not exist) and conditions that can never be true
> > > (./qemu does not exist anymore).
> > 
> > Can we point to a commit id where we stopped making ./qemu?
> 
> commit 9aed1e036dc0de49d08d713f9e5c4655e94acb56
> Author: Anthony Liguori <address@hidden>
> Date:   Mon Aug 29 09:55:36 2011 -0500
> 
>     Rename qemu -> qemu-system-i386
>     
>     This has been discussed before in the past.  The special casing really 
> makes no
>     sense anymore.  This seems like a good change to make for 1.0.
>     
>     Signed-off-by: Anthony Liguori <address@hidden>

This is not related to ./qemu in the qemu-iotests directory. It's just
the name of the binary that is created in i386-softmmu/, but that has
never been the working directory for qemu-iotests.

> > Is it still worth supporting a local symlink?
> 
> Not sure who would have one...

I have always been using symlinks in the qemu-iotests directory. And, as
you probably expect now, ./qemu does exist in my setup.

Now, I must admit that I haven't actually made real use of it recently
because the symlinks only point to the binaries that qemu-iotests would
pick up anyway. But when running qemu-iotests against a different qemu
version or installed binaries instead of whatever is in the build tree,
I always found the symlinks more convenient that setting up a bunch of
environment variables.

So maybe supporting them isn't completely useless.

Kevin