[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2: move qcow2_store_persistent
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] qcow2: move qcow2_store_persistent_dirty_bitmaps() before cache flushing |
Date: |
Wed, 6 Sep 2017 14:40:50 +0200 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
Am 06.09.2017 um 10:19 hat Pavel Butsykin geschrieben:
> On 05.09.2017 22:30, Eric Blake wrote:
> > On 09/04/2017 05:18 AM, Pavel Butsykin wrote:
> > > After calling qcow2_inactivate(), all qcow2 caches must be flushed, but
> > > this
> > > may not happen, because the last call
> > > qcow2_store_persistent_dirty_bitmaps()
> > > can lead to marking l2/refcont cache as dirty.
> > >
> > > Let's move qcow2_store_persistent_dirty_bitmaps() before the caсhe
> > > flushing
> > > to fix it.
> > >
> > > Signed-off-by: Pavel Butsykin <address@hidden>
> > > ---
> > > block/qcow2.c | 16 ++++++++--------
> > > 1 file changed, 8 insertions(+), 8 deletions(-)
> > >
> >
> > Should this cc: qemu-stable?
>
> The latest stable branch (2.8?) doesn't contain the persistent dirty bitmap.
Cc: qemu-stable would now be for qemu 2.10.1, which I think does need
the fix. I'm adding the tag.
Thanks, applied to the block branch.
Kevin