[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] misc: Remove unused Error variable
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH] misc: Remove unused Error variables |
|
Date: |
Tue, 29 Aug 2017 09:40:35 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 08/29/2017 07:08 AM, Alberto Garcia wrote:
> There's a few cases which we're passing an Error pointer to a function
> only to discard it immediately afterwards without checking it. In
> these cases we can simply remove the variable and pass NULL instead.
Could also go in via qemu-trivial or Markus' error tree (both added in
cc) if the block maintainers don't take it quickly.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block/qcow.c | 12 +++---------
> block/qcow2.c | 8 ++------
> dump.c | 4 +---
> 3 files changed, 6 insertions(+), 18 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature