qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] misc: Remove unused Error variable


From: Alberto Garcia
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] misc: Remove unused Error variables
Date: Tue, 29 Aug 2017 15:12:24 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Tue 29 Aug 2017 02:31:35 PM CEST, Philippe Mathieu-Daudé wrote:

>> There's a few cases which we're passing an Error pointer to a function
>> only to discard it immediately afterwards without checking it. In
>> these cases we can simply remove the variable and pass NULL instead.
>
> How did you notice?

I noticed it while I was working on something else. It's also not the
first time I see something like this (see e.g. 026ac1586bdbd184e240).

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]