[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v8 5/6] block: add throttle block filter driver
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH v8 5/6] block: add throttle block filter driver |
Date: |
Fri, 25 Aug 2017 11:47:38 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 24 Aug 2017 02:06:00 PM CEST, Manos Pitsidianakis wrote:
> +bool throttle_group_exists(const char *name)
> +{
> + return throttle_group_by_name(name) != NULL;
> +}
I realized that you needed to add throttle_group_exists() after all
because you need it in block/throttle.c
> /* error if name is duplicate */
> - if (throttle_group_by_name(tg->name) != NULL) {
> + if (throttle_group_exists(tg->name)) {
> error_setg(errp, "A group with this name already exists");
> return;
> }
In that case you can also add it directly in patch #4 so you don't need
to change this line here.
But I won't oppose if you prefer to keep it like this, so either way
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-block] [PATCH v8 0/6] add throttle block driver filter, Manos Pitsidianakis, 2017/08/24
- [Qemu-block] [PATCH v8 3/6] block: tidy ThrottleGroupMember initializations, Manos Pitsidianakis, 2017/08/24
- [Qemu-block] [PATCH v8 4/6] block: convert ThrottleGroup to object with QOM, Manos Pitsidianakis, 2017/08/24
- [Qemu-block] [PATCH v8 5/6] block: add throttle block filter driver, Manos Pitsidianakis, 2017/08/24
- Re: [Qemu-block] [PATCH v8 5/6] block: add throttle block filter driver,
Alberto Garcia <=
- [Qemu-block] [PATCH v8 2/6] block: add aio_context field in ThrottleGroupMember, Manos Pitsidianakis, 2017/08/24
- [Qemu-block] [PATCH v8 1/6] block: move ThrottleGroup membership to ThrottleGroupMember, Manos Pitsidianakis, 2017/08/24
- [Qemu-block] [PATCH v8 6/6] qemu-iotests: add 184 for throttle filter driver, Manos Pitsidianakis, 2017/08/24