[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] qemu-iotests: test NBD over UNIX domain soc
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 3/3] qemu-iotests: test NBD over UNIX domain sockets in 083 |
Date: |
Thu, 24 Aug 2017 12:45:21 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/24/2017 10:33 AM, Stefan Hajnoczi wrote:
> 083 only tests TCP. Some failures might be specific to UNIX domain
> sockets.
>
> A few adjustments are necessary:
>
> 1. Generating a port number and waiting for server startup is
> TCP-specific. Use the new nbd-fault-injector.py startup protocol to
> fetch the address. This is a little more elegant because we don't
> need netstat anymore.
>
> 2. The NBD filter does not work for the UNIX domain sockets URIs we
> generate and must be extended.
>
> 3. Run all tests twice: once for TCP and once for UNIX domain sockets.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/qemu-iotests/083 | 138 +++++++++++++++++++++++--------------
> tests/qemu-iotests/083.out | 145
> ++++++++++++++++++++++++++++++++++-----
> tests/qemu-iotests/common.filter | 4 +-
> 3 files changed, 215 insertions(+), 72 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH 2/3] qemu-iotests: improve nbd-fault-injector.py startup protocol, Stefan Hajnoczi, 2017/08/24
[Qemu-block] [PATCH 3/3] qemu-iotests: test NBD over UNIX domain sockets in 083, Stefan Hajnoczi, 2017/08/24
- Re: [Qemu-block] [PATCH 3/3] qemu-iotests: test NBD over UNIX domain sockets in 083,
Eric Blake <=
Re: [Qemu-block] [PATCH 0/3] nbd-client: enter read_reply_co during init to avoid crash, Eric Blake, 2017/08/24