[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 10/10] scsi: add persistent reservation manager
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper |
Date: |
Wed, 23 Aug 2017 09:48:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 23/08/2017 06:49, Fam Zheng wrote:
>> +
>> + /* A simple feature negotation protocol, even though there is
>> + * no optional feature right now.
>> + */
>> + if (pr_manager_helper_read(pr_mgr, &flags, sizeof(flags), errp) < 0) {
> Not returning the return value of pr_manager_helper_read()?.
>
>> + return -EINVAL;
>> + }
>> +
>> + flags = 0;
>> + if (pr_manager_helper_write(pr_mgr, -1, &flags, sizeof(flags), errp) <
>> 0) {
>> + return -EINVAL;
> Same here.
>
Sorry, I forgot to answer these. The QIOChannel functions (and thus
pr_manager_helper_read/write) only answer -1 or QIO_CHANNEL_ERROR_BLOCK.
I'll change read/write to return -EINVAL instead.
Paolo
- [Qemu-block] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, (continued)
- [Qemu-block] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Paolo Bonzini, 2017/08/22
- Re: [Qemu-block] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Fam Zheng, 2017/08/23
- Re: [Qemu-block] [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Eric Blake, 2017/08/24
- Re: [Qemu-block] [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Daniel P. Berrange, 2017/08/30
- Re: [Qemu-block] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management, Stefan Hajnoczi, 2017/08/30
- [Qemu-block] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper, Paolo Bonzini, 2017/08/22
- [Qemu-block] [PATCH 07/10] io: add qio_channel_read/write_all, Paolo Bonzini, 2017/08/22
- [Qemu-block] [PATCH 09/10] scsi: add multipath support to qemu-pr-helper, Paolo Bonzini, 2017/08/22