[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 4/5] qcow2: Drop debugging dump_refcounts()
From: |
Eric Blake |
Subject: |
[Qemu-block] [PATCH v2 4/5] qcow2: Drop debugging dump_refcounts() |
Date: |
Wed, 9 Aug 2017 15:38:07 -0500 |
It's been #if 0'd since its introduction in 2006, commit 585f8587.
We can revive dead code if we need it, but in the meantime, it has
bit-rotted (for example, not checking for failure in bdrv_getlength()).
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: John Snow <address@hidden>
---
block/qcow2.c | 21 ---------------------
1 file changed, 21 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index d7c600b5a2..99407403ea 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3798,27 +3798,6 @@ static ImageInfoSpecific
*qcow2_get_specific_info(BlockDriverState *bs)
return spec_info;
}
-#if 0
-static void dump_refcounts(BlockDriverState *bs)
-{
- BDRVQcow2State *s = bs->opaque;
- int64_t nb_clusters, k, k1, size;
- int refcount;
-
- size = bdrv_getlength(bs->file->bs);
- nb_clusters = size_to_clusters(s, size);
- for(k = 0; k < nb_clusters;) {
- k1 = k;
- refcount = get_refcount(bs, k);
- k++;
- while (k < nb_clusters && get_refcount(bs, k) == refcount)
- k++;
- printf("%" PRId64 ": refcount=%d nb=%" PRId64 "\n", k, refcount,
- k - k1);
- }
-}
-#endif
-
static int qcow2_save_vmstate(BlockDriverState *bs, QEMUIOVector *qiov,
int64_t pos)
{
--
2.13.4
- [Qemu-block] [PATCH for-2.10 v2 0/5] More bdrv_getlength() fixes, Eric Blake, 2017/08/09
- [Qemu-block] [PATCH v2 1/5] vpc: Check failure of bdrv_getlength(), Eric Blake, 2017/08/09
- [Qemu-block] [PATCH v2 3/5] qcow: Check failure of bdrv_getlength() and bdrv_truncate(), Eric Blake, 2017/08/09
- [Qemu-block] [PATCH v2 2/5] qcow: Change signature of get_cluster_offset(), Eric Blake, 2017/08/09
- [Qemu-block] [PATCH v2 4/5] qcow2: Drop debugging dump_refcounts(),
Eric Blake <=
- [Qemu-block] [PATCH v2 5/5] qcow2: Check failure of bdrv_getlength(), Eric Blake, 2017/08/09
- Re: [Qemu-block] [PATCH for-2.10 v2 0/5] More bdrv_getlength() fixes, Kevin Wolf, 2017/08/10