[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 01/17] nbd/client: fix nbd_opt_go
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] [PATCH 01/17] nbd/client: fix nbd_opt_go |
Date: |
Fri, 4 Aug 2017 18:14:24 +0300 |
Do not send NBD_OPT_ABORT to the broken server. After sending
NBD_REP_ACK on NBD_OPT_GO server is most probably in transmission
phase, when option sending is finished.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
nbd/client.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/nbd/client.c b/nbd/client.c
index 0a17de80b5..f1c16b588f 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -399,12 +399,10 @@ static int nbd_opt_go(QIOChannel *ioc, const char
*wantname,
phase, but make sure it sent flags */
if (len) {
error_setg(errp, "server sent invalid NBD_REP_ACK");
- nbd_send_opt_abort(ioc);
return -1;
}
if (!info->flags) {
error_setg(errp, "broken server omitted NBD_INFO_EXPORT");
- nbd_send_opt_abort(ioc);
return -1;
}
trace_nbd_opt_go_success();
--
2.11.1
- Re: [Qemu-block] [Qemu-devel] [PATCH 07/17] block/nbd-client: refactor request send/receive, (continued)
- [Qemu-block] [PATCH 11/17] block/nbd-client: fix nbd_co_request: set s->reply.handle to 0 on error, Vladimir Sementsov-Ogievskiy, 2017/08/04
- [Qemu-block] [PATCH 08/17] block/nbd-client: rename nbd_recv_coroutines_enter_all, Vladimir Sementsov-Ogievskiy, 2017/08/04
- [Qemu-block] [PATCH 09/17] block/nbd-client: move nbd_co_receive_reply content into nbd_co_request, Vladimir Sementsov-Ogievskiy, 2017/08/04
- [Qemu-block] [PATCH 15/17] block/nbd-client: refactor reading reply, Vladimir Sementsov-Ogievskiy, 2017/08/04
- [Qemu-block] [PATCH 01/17] nbd/client: fix nbd_opt_go,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH 05/17] block/nbd-client: get rid of ssize_t, Vladimir Sementsov-Ogievskiy, 2017/08/04
- Re: [Qemu-block] [PATCH 05/17] block/nbd-client: get rid of ssize_t, Eric Blake, 2017/08/25
- [Qemu-block] [PATCH 02/17] nbd/client: refactor nbd_read_eof, Vladimir Sementsov-Ogievskiy, 2017/08/04