[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 5/6] hw/block: Use errp directly rather than
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v2 5/6] hw/block: Use errp directly rather than local_err |
Date: |
Fri, 4 Aug 2017 13:53:16 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Aug 04, 2017 at 06:26:42PM +0800, Mao Zhongyi wrote:
> Pass the error message to errp directly rather than the local
> variable local_err and propagate it to errp via error_propagate().
>
> Cc: John Snow <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Cc: Keith Busch <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Markus Armbruster <address@hidden>
>
> Signed-off-by: Mao Zhongyi <address@hidden>
> ---
> hw/block/fdc.c | 17 ++++++-----------
> hw/block/nvme.c | 8 +++-----
> hw/block/virtio-blk.c | 17 +++++------------
> hw/ide/qdev.c | 12 ++++--------
> hw/scsi/scsi-disk.c | 13 ++++---------
> hw/usb/dev-storage.c | 9 +++------
> 6 files changed, 25 insertions(+), 51 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v2 0/6] Convert to realize and improve error handling, Mao Zhongyi, 2017/08/04
- [Qemu-block] [PATCH v2 3/6] hw/block/nvme: Convert to realize, Mao Zhongyi, 2017/08/04
- [Qemu-block] [PATCH v2 2/6] hw/block/fdc: Convert to realize, Mao Zhongyi, 2017/08/04
- [Qemu-block] [PATCH v2 4/6] hw/block: Fix the return type, Mao Zhongyi, 2017/08/04
- [Qemu-block] [PATCH v2 6/6] dev-storage: Fix the unusual function name, Mao Zhongyi, 2017/08/04
- [Qemu-block] [PATCH v2 1/6] hw/ide: Convert DeviceClass init to realize, Mao Zhongyi, 2017/08/04
- [Qemu-block] [PATCH v2 5/6] hw/block: Use errp directly rather than local_err, Mao Zhongyi, 2017/08/04
- Re: [Qemu-block] [PATCH v2 5/6] hw/block: Use errp directly rather than local_err,
Stefan Hajnoczi <=