[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 7/7] block: add throttle block filter driver
|
From: |
Manos Pitsidianakis |
|
Subject: |
Re: [Qemu-block] [PATCH v3 7/7] block: add throttle block filter driver interface tests |
|
Date: |
Thu, 3 Aug 2017 16:24:55 +0300 |
|
User-agent: |
NeoMutt/20170609-57-1e93be (1.8.3) |
On Thu, Aug 03, 2017 at 10:07:50AM +0200, Kevin Wolf wrote:
Am 31.07.2017 um 11:54 hat Manos Pitsidianakis geschrieben:
Signed-off-by: Manos Pitsidianakis <address@hidden>
I would add at least two more cases:
* Both limits and throttle-group are given in blockdev-add
This exists in the "property changes in ThrottleGroup" section,
* limits and throttle-group are both missing
this creates an anonymous group with no limits. Should we fail at this
case?
It would also be nice to test that query-block reflects the new throttle
group limits correctly when they are changed after the fact.
This belongs to the remove legacy patch, since query-block displays the
legacy limits.
signature.asc
Description: PGP signature