|
From: | John Snow |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH v4 08/21] mirror: Switch MirrorBlockJob to byte-based |
Date: | Wed, 5 Jul 2017 20:14:28 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 07/05/2017 05:08 PM, Eric Blake wrote: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Continue by converting an > internal structure (no semantic change), and all references to the > buffer size. > > Add an assertion that our use of s->granularity >> BDRV_SECTOR_BITS > (necessary for interaction with sector-based dirty bitmaps, until > a later patch converts those to be byte-based) does not suffer from > truncation problems. > > [checkpatch has a false positive on use of MIN() in this patch] > > Signed-off-by: Eric Blake <address@hidden> > Reviewed-by: John Snow <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |