[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callback
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn |
Date: |
Wed, 5 Jul 2017 12:53:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 05/07/2017 00:03, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> include/block/block_int.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/block/block_int.h b/include/block/block_int.h
> index 15fa602150..93eb2a9528 100644
> --- a/include/block/block_int.h
> +++ b/include/block/block_int.h
> @@ -133,15 +133,15 @@ struct BlockDriver {
> void (*bdrv_refresh_filename)(BlockDriverState *bs, QDict *options);
>
> /* aio */
> - BlockAIOCB *(*bdrv_aio_readv)(BlockDriverState *bs,
> + BlockAIOCB * coroutine_fn (*bdrv_aio_readv)(BlockDriverState *bs,
> int64_t sector_num, QEMUIOVector *qiov, int nb_sectors,
> BlockCompletionFunc *cb, void *opaque);
> - BlockAIOCB *(*bdrv_aio_writev)(BlockDriverState *bs,
> + BlockAIOCB * coroutine_fn (*bdrv_aio_writev)(BlockDriverState *bs,
> int64_t sector_num, QEMUIOVector *qiov, int nb_sectors,
> BlockCompletionFunc *cb, void *opaque);
> - BlockAIOCB *(*bdrv_aio_flush)(BlockDriverState *bs,
> + BlockAIOCB * coroutine_fn (*bdrv_aio_flush)(BlockDriverState *bs,
> BlockCompletionFunc *cb, void *opaque);
> - BlockAIOCB *(*bdrv_aio_pdiscard)(BlockDriverState *bs,
> + BlockAIOCB * coroutine_fn (*bdrv_aio_pdiscard)(BlockDriverState *bs,
> int64_t offset, int bytes,
> BlockCompletionFunc *cb, void *opaque);
>
> @@ -247,7 +247,7 @@ struct BlockDriver {
> void (*bdrv_lock_medium)(BlockDriverState *bs, bool locked);
>
> /* to control generic scsi devices */
> - BlockAIOCB *(*bdrv_aio_ioctl)(BlockDriverState *bs,
> + BlockAIOCB * coroutine_fn (*bdrv_aio_ioctl)(BlockDriverState *bs,
> unsigned long int req, void *buf,
> BlockCompletionFunc *cb, void *opaque);
> int coroutine_fn (*bdrv_co_ioctl)(BlockDriverState *bs,
>
They are, but it's an implementation detail. Why is this patch necessary?
Thanks,
Paolo
- [Qemu-block] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/04
- Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn,
Paolo Bonzini <=
- Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05
- Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Marc-André Lureau, 2017/07/05
- Re: [Qemu-block] [Qemu-devel] [PATCH 08/35] block: all bdrv_aio callbacks are coroutine_fn, Paolo Bonzini, 2017/07/05