[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle t
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI |
Date: |
Wed, 28 Jun 2017 15:35:48 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 23 Jun 2017 02:46:57 PM CEST, Manos Pitsidianakis wrote:
> +# @BlockdevOptionsThrottle:
> +#
> +# Driver specific block device options for Throttle
> +#
I would put this earlier in the json file, together with the rest of the
BlockdevOptions* structs.
> +# @throttling-group: the name of the throttling group to use
Why not call it simply "group" ?
> +#
> +# @options: BlockIOThrottle options
> +# Since: 2.9
> +##
> +{ 'struct': 'BlockdevOptionsThrottle',
> + 'data': { 'throttling-group': 'str',
> + 'file' : 'BlockdevRef',
> + '*options' : 'BlockIOThrottle'
> + } }
Not sure if 'file' is the best name for the field ("child"?), but I'm
fine with it.
Berto
- Re: [Qemu-block] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM, (continued)
- Re: [Qemu-block] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM, Manos Pitsidianakis, 2017/06/26
- Re: [Qemu-block] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM, Stefan Hajnoczi, 2017/06/27
- Re: [Qemu-block] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM, Alberto Garcia, 2017/06/27
- Re: [Qemu-block] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM, Manos Pitsidianakis, 2017/06/27
- Re: [Qemu-block] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM, Stefan Hajnoczi, 2017/06/28
[Qemu-block] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI, Manos Pitsidianakis, 2017/06/23
[Qemu-block] [PATCH RFC v3 6/8] block: add options parameter to bdrv_new_open_driver(), Manos Pitsidianakis, 2017/06/23
[Qemu-block] [PATCH RFC v3 7/8] block: remove legacy I/O throttling, Manos Pitsidianakis, 2017/06/23