[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] block: Tweak error message related to qemu-img
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH] block: Tweak error message related to qemu-img convert |
Date: |
Fri, 19 May 2017 17:07:31 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/19/2017 08:30 AM, Max Reitz wrote:
> On 2017-05-08 19:13, Eric Blake wrote:
>> When converting a 1.1 image down to 0.10, qemu-iotests 060 forces
>> a contrived failure where allocating a cluster used to replace a
>> zero cluster reads unaligned data. Since it is a zero cluster
>> rather than a data cluster being converted, changing the error
>> message to match our earlier change in 'qcow2: Make distinction
>> bewteen zero cluster types obvious' is worthwhile.
I really had problems with that commit message. If you want to re-stage,
you could s/bewteen/between/
>>
>> Suggested-by: Max Reitz <address@hidden>
>> Signed-off-by: Eric Blake <address@hidden>
>> ---
>>
>> There's one more instance of "Data cluster offset" in qcow2-cluster.c,
>> but that one in handle_copied() is contained inside a
>> cluster_type == QCOW2_CLUSTER_NORMAL conditional.
>>
>> block/qcow2-cluster.c | 3 ++-
>> tests/qemu-iotests/060.out | 2 +-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> Assuming no objection means consent:
Okay by me.
>
> Thanks, fixed the commit title and applied to my block branch:
>
> https://github.com/XanClic/qemu/commits/block
>
> Max
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature