[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] ide: export rotational qdev pr
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] ide: export rotational qdev property |
Date: |
Mon, 8 May 2017 10:50:38 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/06/2017 08:43 AM, Aurelien Jarno wrote:
> Export the rotational qdev property in the IDENTIFY request.
>
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
> hw/ide/core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/ide/core.c b/hw/ide/core.c
> index 0b48b64d3a..1aa76b0d90 100644
> --- a/hw/ide/core.c
> +++ b/hw/ide/core.c
> @@ -191,6 +191,9 @@ static void ide_identify(IDEState *s)
> if (dev && dev->conf.discard_granularity) {
> put_le16(p + 169, 1); /* TRIM support */
> }
> + if (dev && !dev->conf.rotational) {
> + put_le16(p + 217, 1); /* non-rotating device */
> + }
>
> ide_identify_size(s);
> s->identify_set = 1;
>
7.16.7.80 Word 217: Nominal media rotation rate
Word 217 is a copy of Nominal Media Rotation Rate (see A.11.5.4).
*flips page like it's a choose-your-own-adventure book*
OK, so 0x0001 just means "Non-rotational." I guess it probably does not
matter that our default is "Rate not reported."
Looks like there's no relevant bits for packet identify data either, so:
Acked-by: John Snow <address@hidden>
A question about the series as a whole, though: if by default rotational
is set to false, we will newly be setting this bit in IDENTIFY data with
identical CLI invocations. Why is that OK?
- [Qemu-block] [PATCH 1/3] hw/block: Introduce rotational qdev property, Aurelien Jarno, 2017/05/06
- [Qemu-block] [PATCH 2/3] scsi-disk: export rotational qdev property, Aurelien Jarno, 2017/05/06
- [Qemu-block] [PATCH 3/3] ide: export rotational qdev property, Aurelien Jarno, 2017/05/06
- Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] hw/block: Introduce rotational qdev property, Philippe Mathieu-Daudé, 2017/05/06
- Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] hw/block: Introduce rotational qdev property, Eric Blake, 2017/05/06
- Re: [Qemu-block] [Qemu-devel] [PATCH 1/3] hw/block: Introduce rotational qdev property, Stefan Hajnoczi, 2017/05/08
- Re: [Qemu-block] [PATCH 1/3] hw/block: Introduce rotational qdev property, Kevin Wolf, 2017/05/09