[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/6] migration: Unify block node ac
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/6] migration: Unify block node activation error handling |
Date: |
Thu, 4 May 2017 12:12:37 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/04/2017 11:52 AM, Kevin Wolf wrote:
> Migration code activates all block driver nodes on the destination when
> the migration completes. It does so by calling
> bdrv_invalidate_cache_all() and blk_resume_after_migration(). There is
> one code path for precopy and one for postcopy migration, resulting in
> four function calls, which used to have three different failure modes.
>
> This patch unifies the behaviour so that failure to activate all block
> nodes is non-fatal, but the error message is logged and the VM isn't
> automatically started. 'cont' will retry activating the block nodes.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> migration/migration.c | 16 +++++-----------
> migration/savevm.c | 12 +++++-------
> qmp.c | 18 +++++++++---------
> 3 files changed, 19 insertions(+), 27 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/6] block: Fix op blockers for inactive images, Kevin Wolf, 2017/05/04
- [Qemu-block] [PATCH 1/6] migration: Unify block node activation error handling, Kevin Wolf, 2017/05/04
- Re: [Qemu-block] [Qemu-devel] [PATCH 1/6] migration: Unify block node activation error handling,
Eric Blake <=
- [Qemu-block] [PATCH 2/6] block: New BdrvChildRole.activate() for blk_resume_after_migration(), Kevin Wolf, 2017/05/04
- [Qemu-block] [PATCH 3/6] block: Drop permissions when migration completes, Kevin Wolf, 2017/05/04
- [Qemu-block] [PATCH 4/6] block: Inactivate parents before children, Kevin Wolf, 2017/05/04
- [Qemu-block] [PATCH 5/6] block: Fix write/resize permissions for inactive images, Kevin Wolf, 2017/05/04
- [Qemu-block] [PATCH 6/6] file-posix: Remove .bdrv_inactivate/invalidate_cache, Kevin Wolf, 2017/05/04