[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 3/3] qemu-img: Document backing options
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v2 3/3] qemu-img: Document backing options |
Date: |
Fri, 28 Apr 2017 11:38:25 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.04.2017 um 17:36 hat Eric Blake geschrieben:
> On 04/26/2017 08:46 AM, Max Reitz wrote:
> > I think originally the idea was to remove the individual special case
> > options in the long term in favour of the uniform -o. But I don't think
> > the short options have fallen out of use, so we can as well document
> > them again...
> >
> > Maybe we could change the implementation, however, so that the old
> > options are really just aliases for the respective -o version.
>
> As in, a followup patch that adds a paragraph or two to the .texi file
> stating that '-B @var{backing_file}' is shorthand for '-o
> address@hidden'?
First and foremost, I meant in the C code where we have separate
variables for all the shorthand options and then need to handle both
ways explicitly in the code further down. Instead, -B could just
directly add a 'backing_file' key to a QemuOpts (and -o would do the
same instead of building a string that is parsed only later).
But the documentation change that you're suggesting is probably a good
idea as well.
Kevin
pgp2bmHkg7Lpr.pgp
Description: PGP signature