qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling er


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors
Date: Mon, 24 Apr 2017 12:37:56 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

Hi Eric,

On 04/24/2017 11:40 AM, Eric Blake wrote:
On 04/23/2017 09:33 AM, address@hidden wrote:
From: Lidong Chen <address@hidden>

Fix some spelling errors in is_allocated_sectors comment.

Signed-off-by: Lidong Chen <address@hidden>
---
 qemu-img.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c
index df6d165..0b3349c 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1033,8 +1033,8 @@ done:
 }

 /*
- * Returns true iff the first sector pointed to by 'buf' contains at least
- * a non-NUL byte.
+ * Returns true if the first sector pointed to by 'buf' contains at least
+ * a non-NULL byte.

NACK to both changes.  'iff' is an English word that is shorthand for
"if and only if".  "NUL" means the one-byte character, while "NULL"
means the 8-byte (or 4-byte, on 32-bit platform) pointer value.

I agree with Lidong shorthands are not obvious from non-native speaker.

What about this?

* Returns true if (and only if) the first sector pointed to by 'buf' contains
 * at least a non-null character.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]