[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qemu-img: simplify img_convert
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-block] [PATCH] qemu-img: simplify img_convert |
|
Date: |
Thu, 20 Apr 2017 22:05:14 +0800 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, 02/28 14:35, Peter Lieven wrote:
> img_convert has been around before there was an ImgConvertState or
> a block backend, but it has never been modified to directly use
> these structs. Change this by parsing parameters directly into
> the ImgConvertState and directly use BlockBackend where possible.
> Futhermore variable initalization has been reworked and sorted.
>
> Signed-off-by: Peter Lieven <address@hidden>
I see an iotest failure with this patch, in Kevin's block-next tree:
019 1s ... - output mismatch (see 019.out.bad)
--- /stor/work/qemu/tests/qemu-iotests/019.out 2017-04-17 16:19:56.523968474
+0800
+++ 019.out.bad 2017-04-20 22:03:29.868216955 +0800
@@ -1086,8 +1086,8 @@
Checking if backing clusters are allocated when they shouldn't
-0/128 sectors allocated at offset 1 MiB
-0/128 sectors allocated at offset 4.001 GiB
+128/128 sectors allocated at offset 1 MiB
+128/128 sectors allocated at offset 4.001 GiB
Reading
=== IO: pattern 42
Failures: 019
Failed 1 of 1 tests