Re: [Qemu-block] [Qemu-devel] [PATCH RFC 3/3] qemu-io: Add --unsafe-read option

[Fam Zheng]

On Tue, 04/18 08:27, Eric Blake wrote:
> On 03/13/2017 09:39 PM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  qemu-io.c | 28 +++++++++++++++++++++-------
> >  1 file changed, 21 insertions(+), 7 deletions(-)
> > 
> > @@ -108,6 +112,7 @@ static void open_help(void)
> >  " -r, -- open file read-only\n"
> >  " -s, -- use snapshot file\n"
> >  " -n, -- disable host cache, short for -t none\n"
> > +" -U, -- accept unsafe opening of the image even if it's in use by another 
> > process\n"
> 
> Long line (exceeds 80 columns of output); can we shorten it?  Maybe
> 
>  -U, allow unsafe reads when another process is writing
> 
> You did get 'qemu-io -c "help open"' adjusted, but I don't see where you
> adjusted 'qemu-io --help'.  Since both places gained a -U, you still
> need more documentation. But at least there is no man page to worry
> about here.

Sounds good. will fix both issues.

Many thanks for the review!

Fam