[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v4 2/6] replication: add shared-dis
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v4 2/6] replication: add shared-disk and shared-disk-id options |
Date: |
Wed, 12 Apr 2017 09:28:07 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/12/2017 09:05 AM, zhanghailiang wrote:
> We use these two options to identify which disk is
> shared
>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: Zhang Chen <address@hidden>
> ---
> v4:
> - Add proper comment for primary_disk (Stefan)
> v2:
> - Move g_free(s->shared_disk_id) to the common fail process place (Stefan)
> - Fix comments for these two options
> ---
> +++ b/qapi/block-core.json
> @@ -2661,12 +2661,20 @@
> # node who owns the replication node chain. Must not be given in
> # primary mode.
> #
> +# @shared-disk-id: Id of shared disk while is replication mode, if
> @shared-disk
> +# is true, this option is required (Since: 2.10)
> +#
> +# @shared-disk: To indicate whether or not a disk is shared by primary VM
> +# and secondary VM. (The default is false) (Since: 2.10)
> +#
> # Since: 2.9
> ##
> { 'struct': 'BlockdevOptionsReplication',
> 'base': 'BlockdevOptionsGenericFormat',
> 'data': { 'mode': 'ReplicationMode',
> - '*top-id': 'str' } }
> + '*top-id': 'str',
> + '*shared-disk-id': 'str',
> + '*shared-disk': 'bool' } }
Do we need a separate bool and string? Or is it sufficient to say that
if shared-disk is omitted, we are not sharing, and that if a shared-disk
string is present, then we are sharing and it names the id of the shared
disk.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v4 0/6] COLO block replication supports shared disk case, zhanghailiang, 2017/04/12
- [Qemu-block] [PATCH v4 5/6] replication: Implement block replication for shared disk case, zhanghailiang, 2017/04/12
- [Qemu-block] [PATCH v4 2/6] replication: add shared-disk and shared-disk-id options, zhanghailiang, 2017/04/12
- [Qemu-block] [PATCH v4 1/6] docs/block-replication: Add description for shared-disk case, zhanghailiang, 2017/04/12
- [Qemu-block] [PATCH v4 3/6] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint(), zhanghailiang, 2017/04/12
- [Qemu-block] [PATCH v4 4/6] replication: fix code logic with the new shared_disk option, zhanghailiang, 2017/04/12
- [Qemu-block] [PATCH v4 6/6] nbd/replication: implement .bdrv_get_info() for nbd and replication driver, zhanghailiang, 2017/04/12