[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.10 7/9] block/rbd - update variable names
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH for-2.10 7/9] block/rbd - update variable names to more apt names |
Date: |
Fri, 7 Apr 2017 10:47:54 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Apr 05, 2017 at 02:28:49PM -0400, Jeff Cody wrote:
> Update 'clientname' to be 'user', which tracks better with both
> the QAPI and rados viarable naming.
>
> Update 'name' to be 'image_name', as it indicates the rbd image.
> Naming it 'image' would have been ideal, but we are using that for
> the rados_image_t value returned by rbd_open().
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> block/rbd.c | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 4/9] block: code movement, (continued)
- [Qemu-block] [PATCH for-2.10 6/9] block: use bdrv_try_set_read_only() during reopen, Jeff Cody, 2017/04/05
- [Qemu-block] [PATCH for-2.10 7/9] block/rbd - update variable names to more apt names, Jeff Cody, 2017/04/05
- Re: [Qemu-block] [PATCH for-2.10 7/9] block/rbd - update variable names to more apt names,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH for-2.10 8/9] block/rbd: do not blindly set bs->read_only, Jeff Cody, 2017/04/05
- [Qemu-block] [PATCH for-2.10 9/9] block/rbd: Add support for reopen(), Jeff Cody, 2017/04/05