Re: [Qemu-block] [Qemu-devel] [RFC 10/19] sysbus-ahci: Remove user_creatable flag

[Alistair Francis]

On Fri, Mar 31, 2017 at 5:46 PM, Eduardo Habkost <address@hidden> wrote:
> The sysbus-ahci devices are supposed to be created and wired by
> code from other devices, like calxeda_init() and
> xlnx_zynqmp_realize(), and won't work with -device. Remove the
> user_creatable flag from the device class.
>
> Cc: John Snow <address@hidden>
> Cc: address@hidden
> Cc: Rob Herring <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Alistair Francis <address@hidden>
> Cc: "Edgar E. Iglesias" <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  hw/ide/ahci.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index b1b7780d56..68f2ce09ee 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1721,11 +1721,6 @@ static void sysbus_ahci_class_init(ObjectClass *klass, 
> void *data)
>      dc->props = sysbus_ahci_properties;
>      dc->reset = sysbus_ahci_reset;
>      set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
> -    /*
> -     * FIXME: Set only for compatibility on q35 machine-type.
> -     * Probably never meant to be user-creatable
> -     */
> -    dc->user_creatable = true;

Part of me thinks this is a step backwards by marking it unsupported.
On the other hand I don't see how this could usefully be connected any
other way.

Reviewed-by: Alistair Francis <address@hidden>

Thanks,

Alistair

>  }
>
>  static const TypeInfo sysbus_ahci_info = {
> --
> 2.11.0.259.g40922b1
>
>