[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [RFC v2 for-2.9 10/10] sheepdog: Fix blockdev-add
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [RFC v2 for-2.9 10/10] sheepdog: Fix blockdev-add |
Date: |
Thu, 30 Mar 2017 10:32:20 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/30/2017 08:15 AM, Markus Armbruster wrote:
> Commit 831acdc "sheepdog: Implement bdrv_parse_filename()" and commit
> d282f34 "sheepdog: Support blockdev-add" have different ideas on how
> the QemuOpts parameters for the server address are named. Fix that.
> While there, rename BlockdevOptionsSheepdog member addr to server, for
> consistency with BlockdevOptionsSsh, BlockdevOptionsGluster,
> BlockdevOptionsNbd.
>
> Commit 831acdc's example becomes
>
> --drive
> driver=sheepdog,server.type=inet,server.host=fido,server.port=7000,vdi=dolly
>
> instead of
>
> --drive driver=sheepdog,host=fido,vdi=dolly
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block/sheepdog.c | 84
> ++++++++++++++++++++++++++++++++++------------------
> qapi/block-core.json | 4 +--
> 2 files changed, 58 insertions(+), 30 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [RFC v2 for-2.9 00/10] Fixes and cleanups around SocketAddress, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 09/10] squash! nbd: Tidy up blockdev-add interface, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 10/10] sheepdog: Fix blockdev-add, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 04/10] block: Document -drive problematic code and bugs, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 05/10] gluster: Prepare for SocketAddressFlat extension, Markus Armbruster, 2017/03/30
- [Qemu-block] [RFC v2 for-2.9 08/10] nbd: Tidy up blockdev-add interface, Markus Armbruster, 2017/03/30