qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it


From: Max Reitz
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH for-2.9] block/archipelago: Make it compile
Date: Wed, 8 Mar 2017 19:32:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1

On 08.03.2017 19:28, Eric Blake wrote:
> On 03/08/2017 12:25 PM, Eric Blake wrote:
>> On 03/08/2017 12:18 PM, Max Reitz wrote:
>>> In order to use error_setg() and similar functions, we need to include
>>> qapi/error.h.
>>>
>>> Signed-off-by: Max Reitz <address@hidden>
>>> ---
>>>  block/archipelago.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Eric Blake <address@hidden>
>>
>> Does this mean our automated buildbots aren't building archipelago by
>> default?
>>
> 
> Oh, I meant to add:
> 
> Should probably mention that it was commit da34e65 that introduced the
> problem (if I'm right?).  Does that mean we have not been compiling
> archipelago.c since Mar 2016?

At least here on my machine it does indeed compile before that commit
and fails afterwards. So, yes, maybe we actually have not. :-)

Max

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]