[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 05/24] test-keyval: Cover use with
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 05/24] test-keyval: Cover use with qobject input visitor |
Date: |
Tue, 28 Feb 2017 19:04:17 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 27.02.2017 um 12:20 hat Markus Armbruster geschrieben:
>> Signed-off-by: Markus Armbruster <address@hidden>
>
>> +static void test_keyval_visit_size(void)
>> +{
>> + Error *err = NULL;
>> + Visitor *v;
>> + QDict *qdict;
>> + uint64_t sz;
>> +
>> + /* Lower limit zero */
>> + qdict = keyval_parse("sz1=0", NULL, &error_abort);
>> + v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
>> + QDECREF(qdict);
>> + visit_start_struct(v, NULL, NULL, 0, &error_abort);
>> + visit_type_size(v, "sz1", &sz, &error_abort);
>> + g_assert_cmpuint(sz, ==, 0);
>> + visit_check_struct(v, &error_abort);
>> + visit_end_struct(v, NULL);
>> + visit_free(v);
>> +
>> + /* Note: precision is 53 bits since we're parsing with strtod() */
>> +
>> + /* Around limit of precision: 2^53-1, 2^53, 2^54 */
>> + qdict = keyval_parse("sz1=9007199254740991,"
>> + "sz2=9007199254740992,"
>> + "sz3=9007199254740993",
>
> That's 2^53+1, not 2^54. With the comment fixed:
D'oh!
> Reviewed-by: Kevin Wolf <address@hidden>
Thanks!
- [Qemu-block] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse, (continued)
- [Qemu-block] [PATCH 10/24] qjson: Abort earlier on qobject_from_jsonf() misuse, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 09/24] libqtest: Fix qmp() & friends to abort on JSON parse errors, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 01/24] test-qemu-opts: Cover qemu_opts_parse() of "no", Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 18/24] block: Initial implementation of -blockdev, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 05/24] test-keyval: Cover use with qobject input visitor, Markus Armbruster, 2017/02/27
- [Qemu-block] [PATCH 03/24] keyval: New keyval_parse(), Markus Armbruster, 2017/02/27
- Re: [Qemu-block] [PATCH 03/24] keyval: New keyval_parse(), Kevin Wolf, 2017/02/28
- Re: [Qemu-block] [Qemu-devel] [PATCH 03/24] keyval: New keyval_parse(), Markus Armbruster, 2017/02/28
- Re: [Qemu-block] [PATCH 03/24] keyval: New keyval_parse(), Eric Blake, 2017/02/28
- Re: [Qemu-block] [Qemu-devel] [PATCH 03/24] keyval: New keyval_parse(), Markus Armbruster, 2017/02/28
- Re: [Qemu-block] [Qemu-devel] [PATCH 03/24] keyval: New keyval_parse(), Eric Blake, 2017/02/28
- Re: [Qemu-block] [Qemu-devel] [PATCH 03/24] keyval: New keyval_parse(), Markus Armbruster, 2017/02/28
[Qemu-block] [PATCH 04/24] qapi: qobject input visitor variant for use with keyval_parse(), Markus Armbruster, 2017/02/27
[Qemu-block] [PATCH 20/24] docs/qapi-code-gen.txt: Clarify naming rules, Markus Armbruster, 2017/02/27