[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PULL 5/5] block/rbd: add support for 'mon

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PULL 5/5] block/rbd: add support for 'mon_host', 'auth_supported' via QAPI
Date: Tue, 28 Feb 2017 10:26:49 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 02/28/2017 10:15 AM, Jeff Cody wrote:
> This adds support for three additional options that may be specified
> by QAPI in blockdev-add:
>     server: host, port
>     auth method: either 'cephx' or 'none'
> The "server" and "auth-supported" QAPI parameters are arrays.  To conform
> with the rados API, the array items are join as a single string with a ';'
> character as a delimiter when setting the configuration values.
> Reviewed-by: Markus Armbruster <address@hidden>

What happened to Signed-off-by? You'll have to resubmit the pull request

> ---
>  block/rbd.c          | 134 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  qapi/block-core.json |  29 +++++++++++
>  2 files changed, 163 insertions(+)

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]