[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PATCH v4 0/5] RBD: blockdev-add (for 2.9?)

From: Jeff Cody
Subject: [Qemu-block] [PATCH v4 0/5] RBD: blockdev-add (for 2.9?)
Date: Tue, 28 Feb 2017 10:51:02 -0500

This series adds blockdev-add for rbd.

Changes from v3:

Patch 5: Encapsulate ipv6 addresses with '[]' (Thanks Daniel, Eric, Markus)
         Free auth_supported (Thanks Markus)
         check error for qdict_array_entries (Thanks Markus)
         Make sure to return NULL on failure (Thanks Markus)
         Misc formatting (Thanks Markus)

Changes from v2:

Patch 2: Updated commit message, and documented the runtime opts
         (Thanks Eric)

Patch 3: Fixed commit type, added "FIXME" in ugly string concat spot
         (Thanks Eric)

Patch 4: Fixed all the nits - deleted lines, spaces.  Kept list 
         alphabetical.  (Thanks Eric)

Patch 5: Significant changes.  Both 'mon_host' became 'server', and an array.
         'auth_supported' became 'auth-supported', and an array.
         (Thanks Daniel, Eric)

          Patch 5 also contains a new function, qemu_rbd_array_opts(), to
          parse the array options.

Changes from v1:


* QAPI interface does not allow arbitrary key/value pairs
  in v2 (Thanks Daniel)

* QAPI interface adds 'mon_host' and 'auth_supported' options (Thanks Daniel)

* Use 'user' instead of 'rbd-id' (Thanks Daniel)
By patch:

Patch 1:
 * Fixed some indentation in patch 1 (Thanks Markus)

Patch 2:
 * 'rbd-id' becomes 'user', and the commit message is fixed. (Thanks Daniel)

Patch 3:
 * Ripple-through from changes in patch 2
 * Removed the string unescape from qemu_rbd_set_keypairs(), because the
   strings have already been unescaped by the time they hit this function.

Patch 4:
 * 'rbd-id' becomes 'user'
 * drop the 'keyvalue-pairs' from the QAPI  (both, thanks Daniel)

Patch 5:
 * new patch
 * Adds the 'server' (mon_host) and 'auth_supported' options to the
   QAPI (Thanks Daniel)

Jeff Cody (5):
  block/rbd: don't copy strings in qemu_rbd_next_tok()
  block/rbd: add all the currently supported runtime_opts
  block/rbd: parse all options via bdrv_parse_filename
  block/rbd: add blockdev-add support
  block/rbd: add support for 'mon_host', 'auth_supported' via QAPI

 block/rbd.c          | 568 ++++++++++++++++++++++++++++++++++-----------------
 qapi/block-core.json |  62 +++++-
 2 files changed, 442 insertions(+), 188 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]