[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3 25/44] commit: Use real permissions in commit

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v3 25/44] commit: Use real permissions in commit block job
Date: Tue, 28 Feb 2017 16:29:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1

On 28.02.2017 13:54, Kevin Wolf wrote:
> This is probably one of the most interesting conversions to the new
> op blocker system because a commit block job intentionally leaves some
> intermediate block nodes in the backing chain that aren't valid on their
> own any more; only the whole chain together results in a valid view.
> In order to provide the 'consistent read' permission to the parents of
> the 'top' node of the commit job, a new filter block driver is inserted
> above 'top' which doesn't require 'consistent read' on its backing
> chain. Subsequently, the commit job can block 'consistent read' on all
> intermediate nodes without causing a conflict.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/commit.c | 113 
> ++++++++++++++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 95 insertions(+), 18 deletions(-)

Thanks for the comment change!

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]