[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v5 02/18] block: add ability to set a prefix for

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v5 02/18] block: add ability to set a prefix for opt names
Date: Wed, 22 Feb 2017 16:18:33 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 21.02.2017 um 12:54 hat Daniel P. Berrange geschrieben:
> When integrating the crypto support with qcow/qcow2, we don't
> want to use the bare LUKS option names "hash-alg", "key-secret",
> etc. We want to namespace them "luks-hash-alg", "luks-key-secret"
> so that they don't clash with any general qcow options at a later
> date.

Or maybe "luks.key-secret", i.e. actually embed the LUKS options QAPI
type into the qcow2 one? In that case, maybe qdict_extract_subqdict()
can even be used before calling into this, so that we don't have to
write a QemuOpts version of the function.

However, the only option I can see at the end of this series in
BlockdevOptionsQcow2 is luks-key-secret, so what happened with this

And if we really have only luks-key-secret (and that not in a separate
sub-dict), I don't really see the need to have separate aes-key-secret
and luks-key-secret options.

> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>

Having said all that, while I'm not sure if the goal of the patch is
completely right, it does seem to correctly implement what it promises.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]