[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 14/54] block: Let callers request permissions wh

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH 14/54] block: Let callers request permissions when attaching a child node
Date: Wed, 22 Feb 2017 14:47:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 21.02.2017 15:58, Kevin Wolf wrote:
> When attaching a node as a child to a new parent, the required and
> shared permissions for this parent are checked against all other parents
> of the node now, and an error is returned if there is a conflict.
> This allows error returns to a function that previously always
> succeeded, and the same is true for quite a few callers and their
> callers. Converting all of them within the same patch would be too much,
> so for now everyone tells that they don't need any permissions and allow
> everyone else to do anything. This way we can use &error_abort initially
> and convert caller by caller to pass actual permission requirements and
> implement error handling.
> All these places are marked with FIXME comments and it will be the job
> of the next patches to clean them up again.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                   | 66 
> +++++++++++++++++++++++++++++++++++++++++------
>  block/block-backend.c     |  8 ++++--
>  include/block/block_int.h | 15 ++++++++++-
>  3 files changed, 78 insertions(+), 11 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]