qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/8] nbd/client: fix drop_sync [


From: Marc-André Lureau
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/8] nbd/client: fix drop_sync [CVE-2017-2630]
Date: Tue, 21 Feb 2017 08:11:08 +0000



On Tue, Feb 21, 2017 at 6:49 AM Eric Blake <address@hidden> wrote:
From: Vladimir Sementsov-Ogievskiy <address@hidden>

Comparison symbol is misused. It may lead to memory corruption.
Introduced in commit 7d3123e.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
[eblake: add CVE details]
Signed-off-by: Eric Blake <address@hidden>


Reviewed-by: Marc-André Lureau <address@hidden>

 
---
 nbd/client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nbd/client.c b/nbd/client.c
index ffb0743..0d16cd1 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -94,7 +94,7 @@ static ssize_t drop_sync(QIOChannel *ioc, size_t size)
     char small[1024];
     char *buffer;

-    buffer = sizeof(small) < size ? small : g_malloc(MIN(65536, size));
+    buffer = sizeof(small) > size ? small : g_malloc(MIN(65536, size));
     while (size > 0) {
         ssize_t count = read_sync(ioc, buffer, MIN(65536, size));

--
2.9.3


--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]