[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 4/6] qemu-img: add support for -o arg to dd c
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-block] [PATCH v2 4/6] qemu-img: add support for -o arg to dd command |
Date: |
Mon, 20 Feb 2017 12:33:33 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, Feb 03, 2017 at 11:07:13PM +0100, Max Reitz wrote:
> On 03.02.2017 13:02, Daniel P. Berrange wrote:
> > The -o arg to the convert command allows specification of format/protocol
> > options for the newly created image. This adds a -o arg to the dd command
> > to get feature parity.
> >
> > Signed-off-by: Daniel P. Berrange <address@hidden>
> > ---
> > qemu-img-cmds.hx | 2 +-
> > qemu-img.c | 32 +++++++++++++++++++++++++++++++-
> > qemu-img.texi | 6 ++++--
> > 3 files changed, 36 insertions(+), 4 deletions(-)
>
> I don't like this patch for the same reasons as for patch 3, but I like
> it a bit better. The code introduced here is exactly the same as for
> img_convert(), so merging the two would (or "is going to", I hope) be
> trivial.
>
> So a pretty weak
>
> Reviewed-by: Max Reitz <address@hidden>
Again, I'll drop this patch for now.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
- [Qemu-block] [PATCH v2 0/6] qemu-img: improve convert & dd commands, Daniel P. Berrange, 2017/02/03
- [Qemu-block] [PATCH v2 4/6] qemu-img: add support for -o arg to dd command, Daniel P. Berrange, 2017/02/03
- [Qemu-block] [PATCH v2 3/6] qemu-img: add support for conv=nocreat, notrunc args to dd command, Daniel P. Berrange, 2017/02/03
- [Qemu-block] [PATCH v2 1/6] qemu-img: add support for --object with 'dd' command, Daniel P. Berrange, 2017/02/03
- [Qemu-block] [PATCH v2 5/6] qemu-img: introduce --target-image-opts for 'convert' command, Daniel P. Berrange, 2017/02/03