[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v5 5/7] blkdebug: Simplify override logic

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v5 5/7] blkdebug: Simplify override logic
Date: Wed, 15 Feb 2017 16:58:22 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

Am 14.02.2017 um 20:25 hat Eric Blake geschrieben:
> Rather than store into a local variable, then copy to the struct
> if the value is valid, then reporting errors otherwise, it is
> simpler to just store into the struct and report errors if the
> value is invalid.  This however requires that the struct store
> a 64-bit number, rather than a narrower type.  Move the errno
> assignment into a label that will be reused from more places in
> the next patch.
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>

Reviewed-by: Kevin Wolf <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]