[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3 1/1] block/vmdk: Fix the endian problem of bu

From: Hao QingFeng
Subject: Re: [Qemu-block] [PATCH v3 1/1] block/vmdk: Fix the endian problem of buf_len and lba
Date: Mon, 13 Feb 2017 17:17:32 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1

在 2017-01-26 0:25, Max Reitz 写道:
On 16.12.2016 06:20, QingFeng Hao wrote:
The problem was triggered by qemu-iotests case 055. It failed when it
was comparing the compressed vmdk image with original test.img.

The cause is that buf_len in vmdk_write_extent wasn't converted to
little-endian before it was stored to disk. But later vmdk_read_extent
read it and converted it from little-endian to cpu endian.
If the cpu is big-endian like s390, the problem will happen and
the data length read by vmdk_read_extent will become invalid!
The fix is to add the conversion in vmdk_write_extent, meanwhile,
repair the endianness problem of lba field which shall also be converted
to little-endian before storing to disk.

Cc: address@hidden
Signed-off-by: QingFeng Hao <address@hidden>
Signed-off-by: Jing Liu <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
  block/vmdk.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, I've applied the patch to my block tree:

Thanks Max!


QingFeng Hao(Robin)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]