[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 2/2] iov: assert that qiov->size doesn't exceed

From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH 2/2] iov: assert that qiov->size doesn't exceed INT_MAX
Date: Wed, 01 Feb 2017 23:00:55 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Wed 01 Feb 2017 10:56:29 PM CET, Max Reitz <address@hidden> wrote:

>> I was actually just reading virtio_blk_handle_request() and I see
>> that the I/O vector is initialized before the check for the maximum
>> request size that returns VIRTIO_BLK_S_IOERR.
>> So you're probably right and it's safer not to add that assertion.
> So... Apply patch 1 and hope we do everything right in the future? :-)

I think patch 1 is definitely necessary and enough to solve the crash
that I reported.

Tomorrow I'll think about what to do in place of the second one :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]