[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH V3 2/2] block/nfs: fix naming of runtime opts

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH V3 2/2] block/nfs: fix naming of runtime opts
Date: Wed, 1 Feb 2017 10:50:48 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 02/01/2017 03:53 AM, Peter Lieven wrote:
> commit 94d6a7a accidently left the naming of runtime opts and QAPI

Whoops - I caught one typo in v2, but missed another:

> scheme inconsistent. As one consequence passing of parameters in the
> URI is broken. Sync the naming of the runtime opts to the QAPI
> scheme.
> Please note that this is technically backwards incompatible with the 2.8
> release, but the 2.8 release is the only version that had the wrong naming.
> Furthermore release 2.8 suffered from a NULL pointer dereference during
> URI parsing.
> Fixes: 94d6a7a76e9df9919629428f6c598e2b97d9426c
> Cc: address@hidden
> Signed-off-by: Peter Lieven <address@hidden>
> ---
>  block/nfs.c | 46 +++++++++++++++++++++++-----------------------
>  1 file changed, 23 insertions(+), 23 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

(Maintainer can probably fix the typo)

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]