[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 24/24] qcow2-bitmap: cache bitmap list in BDRVQc

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH 24/24] qcow2-bitmap: cache bitmap list in BDRVQcow2State
Date: Wed, 1 Feb 2017 13:14:49 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

01.02.2017 02:27, Max Reitz wrote:
On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote:
Do not reload bitmap list every time it is needed.

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
  block/qcow2-bitmap.c | 125 ++++++++++++++++++++++++++++++++++-----------------
  block/qcow2.c        |   2 +
  block/qcow2.h        |   4 ++
  3 files changed, 89 insertions(+), 42 deletions(-)
Hm, difficult. On a glance, this patch seems alright, and it probably
makes sense. Maybe it would make the code actually a bit easier to
understand if it was squashed into the other patches. But OTOH it would
mean that I would have to start review from scratch for those patches...

So in my opinion this patch makes sense and you should keep it updated,
but I think we should keep it separate from the rest of the series. Get
the first 23 patches in first and then we can merge this on top later on.

Would that be OK?

Yes, that's OK.


Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]