[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL for-2.8 01/13] blockjob: fix dead pointer in txn list
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PULL for-2.8 01/13] blockjob: fix dead pointer in txn list |
Date: |
Mon, 14 Nov 2016 23:14:39 -0500 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
Though it is not intended to be reached through normal circumstances,
if we do not gracefully deconstruct the transaction QLIST, we may wind
up with stale pointers in the list.
The rest of this series attempts to address the underlying issues,
but this should fix list inconsistencies.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Tested-by: John Snow <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Signed-off-by: John Snow <address@hidden>
Message-id: address@hidden
[Rewrote commit message. --js]
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Signed-off-by: John Snow <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>
---
blockjob.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/blockjob.c b/blockjob.c
index 4aa14a4..4d0ef53 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -256,6 +256,7 @@ static void block_job_completed_single(BlockJob *job)
}
if (job->txn) {
+ QLIST_REMOVE(job, txn_list);
block_job_txn_unref(job->txn);
}
block_job_unref(job);
--
2.7.4
- [Qemu-block] [PULL for-2.8 00/13] Block patches for 2.8, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 01/13] blockjob: fix dead pointer in txn list,
Jeff Cody <=
- [Qemu-block] [PULL for-2.8 02/13] blockjob: add .clean property, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 03/13] blockjob: add .start field, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 04/13] blockjob: add block_job_start, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 05/13] blockjob: refactor backup_start as backup_job_create, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 06/13] iotests: add transactional failure race test, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 07/13] qemu-iotests: avoid spurious failure on test 109, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 08/13] block/curl: Drop TFTP "support", Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 09/13] block/curl: Use BDRV_SECTOR_SIZE, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 10/13] block/curl: Fix return value from curl_read_cb, Jeff Cody, 2016/11/14
- [Qemu-block] [PULL for-2.8 11/13] block/curl: Remember all sockets, Jeff Cody, 2016/11/14