[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PULL 36/47] pci: Convert msix_init() to Error and fix
From: |
Hannes Reinecke |
Subject: |
Re: [Qemu-block] [PULL 36/47] pci: Convert msix_init() to Error and fix callers to check it |
Date: |
Fri, 11 Nov 2016 07:55:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/10/2016 05:14 PM, Michael S. Tsirkin wrote:
> From: Cao jin <address@hidden>
>
> msix_init() reports errors with error_report(), which is wrong when
> it's used in realize(). The same issue was fixed for msi_init() in
> commit 1108b2f.
>
> For some devices(like e1000e, vmxnet3) who won't fail because of
> msix_init's failure, suppress the error report by passing NULL error object.
>
> Bonus: add comment for msix_init.
>
> CC: Jiri Pirko <address@hidden>
> CC: Gerd Hoffmann <address@hidden>
> CC: Dmitry Fleytman <address@hidden>
> CC: Jason Wang <address@hidden>
> CC: Michael S. Tsirkin <address@hidden>
> CC: Hannes Reinecke <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Alex Williamson <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Marcel Apfelbaum <address@hidden>
>
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Cao jin <address@hidden>
> Acked-by: Marcel Apfelbaum <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> include/hw/pci/msix.h | 5 +++--
> hw/block/nvme.c | 5 ++++-
> hw/misc/ivshmem.c | 8 ++++----
> hw/net/e1000e.c | 6 +++++-
> hw/net/rocker/rocker.c | 7 ++++++-
> hw/net/vmxnet3.c | 8 ++++++--
> hw/pci/msix.c | 34 +++++++++++++++++++++++++++++-----
> hw/scsi/megasas.c | 5 ++++-
> hw/usb/hcd-xhci.c | 13 ++++++++-----
> hw/vfio/pci.c | 8 ++++++--
> hw/virtio/virtio-pci.c | 11 +++++------
> 11 files changed, 80 insertions(+), 30 deletions(-)
>
Reviewed-by: Hannes Reinecke <address@hidden>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
address@hidden +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)