[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 1/1] migration: fix compiler warning on uninitia

From: Hailiang Zhang
Subject: Re: [Qemu-block] [PATCH 1/1] migration: fix compiler warning on uninitialized variable
Date: Tue, 1 Nov 2016 09:12:12 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 2016/11/1 5:50, Jeff Cody wrote:
Some older GCC versions (e.g. 4.4.7) report a warning on an
uninitialized variable for 'request', even though all possible code
paths that reference 'request' will be initialized.   To appease
these versions, initialize the variable to 0.

Thanks for reporting this,  I think this patch can go through trivial

Cc: Michael Tokarev <address@hidden>
Cc: address@hidden

Reported-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>

Reviewed-by: zhanghailiang <address@hidden>

  migration/colo.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/colo.c b/migration/colo.c
index e7224b8..93c85c5 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -439,7 +439,7 @@ void *colo_process_incoming_thread(void *opaque)

      while (mis->state == MIGRATION_STATUS_COLO) {
-        int request;
+        int request = 0;

          colo_wait_handle_message(mis->from_src_file, &request, &local_err);
          if (local_err) {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]