Re: [Qemu-block] [PATCH v5 08/13] qapi: Allow blockdev-add for NBD

[Max Reitz]

On 26.10.2016 01:57, Eric Blake wrote:
> On 10/25/2016 08:11 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>>  qapi/block-core.json | 25 ++++++++++++++++++++++---
>>  1 file changed, 22 insertions(+), 3 deletions(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index 97b1205..4b4a74c 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -1703,14 +1703,15 @@
>>  #
>>  # @host_device, @host_cdrom: Since 2.1
>>  # @gluster: Since 2.7
>> +# @nbd: Since 2.8
> 
> 'replication' was also added in 2.8; we should mention it while touching
> this.
> 
>>  #
>>  # Since: 2.0
>>  ##
>>  { 'enum': 'BlockdevDriver',
>>    'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
>>              'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom',
>> -            'host_device', 'http', 'https', 'luks', 'null-aio', 'null-co',
>> -            'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
>> +            'host_device', 'http', 'https', 'luks', 'nbd', 'null-aio',
>> +            'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw',
>>          'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
> 
> Can we fix the TAB damage while at it?
> 
> Reviewed-by: Eric Blake <address@hidden>

You're completely right with both comments, but I think putting them in
separate patches might be better (we even have time after soft freeze
for this). If the maintainer applying this patch decides to put the tab
fix into this patch while applying, I wouldn't mind, though.

Max

signature.asc
Description: OpenPGP digital signature