[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v4 5/5] qapi: allow blockdev-add for ssh

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v4 5/5] qapi: allow blockdev-add for ssh
Date: Tue, 25 Oct 2016 14:58:40 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 10/25/2016 08:04 AM, Ashijeet Acharya wrote:
> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
> support blockdev-add for SSH network protocol driver. Use only 'struct
> InetSocketAddress' since SSH only supports connection over TCP.
> Signed-off-by: Ashijeet Acharya <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
> ---
>  qapi/block-core.json | 26 ++++++++++++++++++++++++--
>  1 file changed, 24 insertions(+), 2 deletions(-)

Sorry for not noticing this when I finally replied to v4;

> +##
> +# @BlockdevOptionsSsh
> +#
> +# @server:              host address
> +#
> +# @path:                path to the image on the host
> +#
> +# @user:                #optional user as which to connect, defaults to 
> current
> +#                       local user name
> +#
> +# @host_key_check       #optional defines how and what to check the host
> +#                       key against, defaults to "yes"

I still have reservations about this parameter. I think we have time to
fix it as followups during soft freeze if Kevin would rather get your
initial patches in now, if that's what it takes to meet soft freeze
deadlines, but I do not want to bake it into the actual 2.8 release
without addressing those concerns.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]