[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 16/22] qmp: add persistent flag to block-dirty-b
Re: [Qemu-block] [PATCH 16/22] qmp: add persistent flag to block-dirty-bitmap-add
Mon, 24 Oct 2016 17:44:32 +0300
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
07.10.2016 22:52, Eric Blake пишет:
On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote:
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add.
Default is false.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
blockdev.c | 12 +++++++++++-
qapi/block-core.json | 7 ++++++-
qmp-commands.hx | 5 ++++-
This and later patches have conflicts with recent changes in the tree
that removed qmp-commands.hx; hopefully shouldn't impact review of this
series too badly.
@@ -1235,10 +1235,15 @@
# @granularity: #optional the bitmap granularity, default is 64k for
+# @persistent: #optional the bitmap is persistent, i.e. it will be saved to
+# corresponding block device on it's close. Default is false.
("it's" is only appropriate if you can substitute "it is" or "it has")
@@ -1458,6 +1458,9 @@ Arguments:
- "node": device/node on which to create dirty bitmap (json-string)
- "name": name of the new dirty bitmap (json-string)
- "granularity": granularity to track writes with (int, optional)
+- "persistent": bitmap will be saved to corresponding block device
+ on it's close. Block driver should maintain persistent bitmaps
One nice benefit of rebasing on top of qmp-commands.hx being removed is
that you don't have to repeat yourself :)
As I understand, duplicating description is still here, in
docs/qmp-commands.txt. I just don't have to repeat parameters definition
(which is good, anyway)