[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test creating
Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/4] qemu-iotests: Test creating floppy drives
Tue, 18 Oct 2016 14:53:53 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
On 10/18/2016 02:45 PM, John Snow wrote:
> On 10/18/2016 06:22 AM, Kevin Wolf wrote:
>> This tests the different supported methods to create floppy drives and
>> how they interact.
>> +function check_floppy_qtree()
>> + echo
>> + echo Testing: "$@" | _filter_testdir
>> + # QEMU_OPTIONS contains -nodefaults, we don't want that here
>> because the
>> + # defaults are part of what should be checked here
>> + echo "info qtree" |
>> + QEMU_OPTIONS="" do_run_qemu "$@" | _filter_win32 |
>> + grep -zo '[[:cntrl:]]\( *\)dev: isa-fdc.*\([[:cntrl:]]\1
>> .*\)*[[:cntrl:]] *dev:'
> This grep invocation doesn't appear to actually terminate with the '-z'
> option here. Not sure why, I haven't looked into the bash framework
> much, hopefully it's not too hard for you to reproduce and correct.
Is 'grep -z' even portable to BSD, or is it just a GNU extension? Would
it be better to run the output through tr to convert things to a saner
subset of characters before then grepping a text file?
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature