Re: [Qemu-block] [Qemu-devel] [PATCH v2] qapi: fix memory leak in bdrv_image_info_specific_dump

[Eric Blake]

On 10/18/2016 05:37 AM, Pino Toscano wrote:
> The 'obj' result of the visitor was not properly freed, like done in
> other places doing a similar job.
> 
> Signed-off-by: Pino Toscano <address@hidden>
> ---

Reviewed-by: Eric Blake <address@hidden>

> 
> Changes in v2:
> - added Signed-off-by
> 
>  block/qapi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/qapi.c b/block/qapi.c
> index 6f947e3..50d3090 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -698,6 +698,7 @@ void bdrv_image_info_specific_dump(fprintf_function 
> func_fprintf, void *f,
>      assert(qobject_type(obj) == QTYPE_QDICT);
>      data = qdict_get(qobject_to_qdict(obj), "data");
>      dump_qobject(func_fprintf, f, 1, data);
> +    qobject_decref(obj);
>      visit_free(v);
>  }
>  
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature