[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] iotests: drop thread spun work-around

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH] iotests: drop thread spun work-around
Date: Mon, 17 Oct 2016 20:11:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 10.10.2016 04:57, Michael S. Tsirkin wrote:
> We've disabled the warning, no need for test to work
> around it.
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  tests/qemu-iotests/common.filter | 1 -
>  1 file changed, 1 deletion(-)
> diff --git a/tests/qemu-iotests/common.filter 
> b/tests/qemu-iotests/common.filter
> index cfdb633..49217b0 100644
> --- a/tests/qemu-iotests/common.filter
> +++ b/tests/qemu-iotests/common.filter
> @@ -164,7 +164,6 @@ _filter_qemu()
>  {
>      sed -e "s#\\(^\\|(qemu) \\)$(basename $QEMU_PROG):#\1QEMU_PROG:#" \
>          -e 's#^QEMU [0-9]\+\.[0-9]\+\.[0-9]\+ monitor#QEMU X.Y.Z monitor#' \
> -        -e '/main-loop: WARNING: I\/O thread spun for [0-9]\+ iterations/d' \
>          -e $'s#\r##' # QEMU monitor uses \r\n line endings
>  }

I'll have to drop this patch from my queue for now because I noticed the
warnings reappearing. This is because the iotests only use
-machine accel=qtest, but don't create any -qtest character device.

Commit 21a24302e85024dd7b2a151158adbc1f5dc5c4dd changed the behavior so
that the warning will only be emitted if there is a -qtest character
device, reasoning that there are tests that do not use the qtest
accelerator but just the character device. However, this has the
downside of actually printing the warning if qemu is run only under the
qtest accelerator, without a -qtest chardev.

I've sent a patch to remedy this, but until that is merged, I'll have to
hold this patch.

(Also, some iotests do not yet use -machine accel=qtest at all, I'll
have to fix that first, too.)


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]