[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it |
Date: |
Mon, 17 Oct 2016 10:59:50 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/17/2016 10:44 AM, Ashijeet Acharya wrote:
>
> I think, its better to keep using atoi() and check if it returns a '0'
Please not atoi(), as it lacks sane error checking. It cannot tell the
difference between '1' and '1garbage'. It's obvious that you want to
treat both '0' and 'name' as an error, but that is not the only error
you want to flag, thus atoi() is insufficient to flag all the errors you
want.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, (continued)
- [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, Ashijeet Acharya, 2016/10/15
- Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, Kevin Wolf, 2016/10/17
- Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, Ashijeet Acharya, 2016/10/17
- Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, Kevin Wolf, 2016/10/17
- Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, Ashijeet Acharya, 2016/10/17
- Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, Kevin Wolf, 2016/10/17
- Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, Ashijeet Acharya, 2016/10/17
- Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it,
Eric Blake <=
- Re: [Qemu-block] [v2 2/5] block/ssh: Add InetSocketAddress and accept it, Ashijeet Acharya, 2016/10/17
[Qemu-block] [v2 3/5] block/ssh: Use inet_connect_saddr() to establish socket connection, Ashijeet Acharya, 2016/10/15
[Qemu-block] [v2 4/5] block/ssh: Use InetSocketAddress options, Ashijeet Acharya, 2016/10/15
[Qemu-block] [v2 5/5] qapi: allow blockdev-add for ssh, Ashijeet Acharya, 2016/10/15
Re: [Qemu-block] [Qemu-devel] [v2 0/5] Allow blockdev-add for SSH, no-reply, 2016/10/15
Re: [Qemu-block] [v2 0/5] Allow blockdev-add for SSH, Kevin Wolf, 2016/10/17