Re: [Qemu-block] [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes

[Eric Blake]

On 10/13/2016 11:59 PM,
address@hidden wrote:

> Checking PATCH 13/15: nbd: Improve server handling of shutdown requests...
> ERROR: return of an errno should typically be -ve (return -ESHUTDOWN)
> #63: FILE: nbd/client.c:38:
> +        return ESHUTDOWN;
> 
> total: 1 errors, 0 warnings, 95 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.

False positive; although we COULD rewrite the function to do:

ret = ESHUTDOWN;
return ret;

(and so on for all the cases in the switch), to hide the fact that we
intentionally want to return a positive errno value, if it bothers
anyone enough to ask me to do so.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature